Open
Conversation
jayvdb
suggested changes
Oct 29, 2018
jayvdb
reviewed
Oct 29, 2018
dhruvsomani
force-pushed
the
UniqueList
branch
2 times, most recently
from
c04a1f0 to
db0f8dd
Compare
Contributor
Author
myint
requested changes
Nov 11, 2018
Owner
myint
left a comment
myint
left a comment
There was a problem hiding this comment.
A few more requested after I tested this with make check.
dhruvsomani
force-pushed
the
UniqueList
branch
3 times, most recently
from
1d74ecd to
97fb973
Compare
Added the `--unique-list` command line argument which enables to only see the unique errors in a report only manner. Thus, recurring not matching tokens will be lumped together as one. Also, shows the corresponding line numbers where the misspelling occurs. The `list_unique` parameter was added to `spell_check()`, `spell_check_file()` and `spell_check_token()` functions. Closes myint#24
dhruvsomani
force-pushed
the
UniqueList
branch
from
97fb973 to
a3bc78d
Compare
Contributor
Author
|
@myint Done. 😄 |
Owner
|
The indentation is still a bit off. But I"m going approve as I suspect this Google thing will be already over the next time I get a chance to log in. |
myint
approved these changes
Nov 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
--list-uniquecommand line argument which enables to only see the unique errors in a report only manner. Thus, recurring not matching tokens will be lumped together as one. Also, shows a list of line numbers beside the token where the token was used.The list_unique parameter was added to spell_check(), spell_check_file and spell_check_token() functions.
Closes #24