Open
Conversation
Added `spell_check_str` - Doesn't requie file to be on disk - Does not read stdin or write to stdout - Acts as an iterator in the report-only use case - Acts as a coroutine in the auto-apply use case Fixes myint#29 BREAKING CHANGE: `spell_check_token`s API changed
Contributor
Author
When digging into the code, I could not see what impact mutating file_id_ref has.
Proposal:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
file_id_refshould be handledAdded
spell_check_strFixes #29
BREAKING CHANGE:
spell_check_tokens API changed