Fix return types for Doctrine\Persistence\Proxy implementations#203
Merged
mnapoli merged 1 commit intomyclabs:1.xfrom Apr 29, 2025
Merged
Conversation
PHP Fatal error: Declaration of DeepCopyTest\Matcher\Doctrine\FooProxy::__load() must be compatible with Doctrine\Persistence\Proxy::__load(): void
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloning the repo and running
composer installandvendor/bin/phpunitfailed with:PHP Fatal error: Declaration of DeepCopyTest\Matcher\Doctrine\FooProxy::__load() must be compatible with Doctrine\Persistence\Proxy::__load(): voidThis merge request adds the required return-types to
__load(void) and__isInitialized(bool) of Doctrine\Persistence\Proxy implementations.