Open
Conversation
Use `set -euf` to make script safer Commands exit properly on failure Quote variables
Commands exit properly on failure Quote variables
Make script portable Commands exit properly on failure Quote variables Rethink eval arguments
Use `set -euf` to make script safer Commands exit properly on failure Quote variables
Commands exit properly on failure Quote variables Reorganize
Commands exit properly on failure Quote variables Use either curl or wget
Author
|
Let me know if you need help with the review, functionality remained unchanged. |
|
33acfd3d1c15cfb314a5c99695a4c16b83da8793 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safer scripts with
set -eufand other options whenever possibleMake scripts more portable
Quote variables
Use end-of-options (
--) to make scripts saferUse either curl or wget with safer parameters
All commands (even mkdir/cd) exit properly on failure
Rethink eval arguments