Update 002_0008_avoid_read_write_default_access_rule.rego#21
Merged
Conversation
Change object iteration from 'obj[_]' to 'some...in...'; preferred style for readability according to https://docs.styra.com/regal/rules/style/prefer-some-in-iteration Change creating role names list to immediately get second value from split list, instead of assigning them separately to another variable ('parts'). AllowedModuleRoles are always formatted as {moduleName}.{userRoleName}, so when split the user role name is always the second value in the split list. Correct spelling mistake in package name Add related resources (links to Mendix docs) to metadata for future reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change object iteration from 'obj[_]' to 'some...in...'; preferred style for readability according to https://docs.styra.com/regal/rules/style/prefer-some-in-iteration
Change creating role names list to immediately get second value from split list, instead of assigning them separately to another variable ('parts'). AllowedModuleRoles are always formatted as {moduleName}.{userRoleName}, so when split the user role name is always the second value in the split list.
Correct spelling mistake in package name
Add related resources (links to Mendix docs) to metadata for future reference