Skip to content

Fix logger vet format warnings#91

Merged
besendorf merged 2 commits into
mainfrom
fix-logger-vet-format-warnings
May 27, 2026
Merged

Fix logger vet format warnings#91
besendorf merged 2 commits into
mainfrom
fix-logger-vet-format-warnings

Conversation

@besendorf
Copy link
Copy Markdown
Collaborator

Summary

Fix Go vet failures in the logger and logging call sites so go test ./... passes on main.

The root cause was a mix of print-style logger wrappers forwarding variadic arguments through a printf-like helper with an empty format string, plus a few logging calls using %w or an incomplete % directive in non-wrapping log output.

Changes

  • Pass print-style logger arguments through fmt.Sprint with an explicit %s format.
  • Replace logging-only %w directives with %v.
  • Fix one malformed log format string in modules/logs.go.

Validation

  • make collector
  • go test ./...

@besendorf besendorf changed the title [codex] Fix logger vet format warnings Fix logger vet format warnings May 7, 2026
…-warnings

# Conflicts:
#	modules/backup.go
#	modules/bugreport.go
@besendorf besendorf marked this pull request as ready for review May 27, 2026 15:40
@besendorf besendorf merged commit b234322 into main May 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant