Skip to content

Fix acquisition completion timestamp#100

Open
besendorf wants to merge 1 commit into
mainfrom
fix-completed-acquisition-timestamp
Open

Fix acquisition completion timestamp#100
besendorf wants to merge 1 commit into
mainfrom
fix-completed-acquisition-timestamp

Conversation

@besendorf
Copy link
Copy Markdown
Collaborator

Summary

  • Set the acquisition completion timestamp before writing acquisition.json in non-streaming acquisitions.
  • Preserve an already recorded completion timestamp during cleanup so metadata remains consistent.
  • Handle StoreInfo errors and add regression tests for non-zero completed metadata.

Root cause

acquisition.json was written before Complete() populated Completed, so non-streaming acquisitions stored Go's zero timestamp (0001-01-01T00:00:00Z).

Fixes #85.

Validation

  • GOCACHE=/tmp/go-build GOMODCACHE=/tmp/go-mod go test ./...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect completed time in acquisition.json file

1 participant