Implement PCM12 and PCM34 registers#42
Draft
struthiocamelus wants to merge 1 commit intomvdnes:mainfrom
Draft
Conversation
Author
|
I made some assumptions that the u32 amplitude should just lose 28 bits of precision in order to be returned in 2 nibbles. I think that's correct. |
Owner
|
This would be nice to have for some tests in https://github.com/daid/GBEmulatorShootout as well. I am looking forward to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (supposedly) implements the undocumented PCM12 and PCM34 GBC registers that allow reading the current sound amplitudes.
TODO:
0x00on DMG and other non CGB models.