Skip to content

Fix Core Data threading problem with AFMMRecordResponseSerializer. The ... #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonbrooks wants to merge 1 commit into from
Closed

Fix Core Data threading problem with AFMMRecordResponseSerializer. The ... #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions Source/AFMMRecordResponseSerializer/AFMMRecordResponseSerializer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,15 @@ - (NSManagedObjectContext *)backgroundContext {

- (NSArray *)recordsFromMMRecordResponse:(MMRecordResponse *)recordResponse
backgroundContext:(NSManagedObjectContext *)backgroundContext {
__block NSMutableArray *objectIDs = [NSMutableArray array];
NSMutableArray *objectIDs = [NSMutableArray array];

[backgroundContext performBlockAndWait:^{
NSError *error;
NSArray *records = [recordResponse records];
if (![backgroundContext save:&error]) {
NSLog(@"%s encountered error saving: %@", __PRETTY_FUNCTION__, error);
return;
}

for (MMRecord *record in records) {
[objectIDs addObject:[record objectID]];
Expand All @@ -120,9 +125,12 @@ - (NSArray *)recordsFromMMRecordResponse:(MMRecordResponse *)recordResponse

NSMutableArray *records = [NSMutableArray array];

for (NSManagedObjectID *objectID in objectIDs) {
[records addObject:[self.context objectWithID:objectID]];
}

[self.context performBlockAndWait:^{
for (NSManagedObjectID *objectID in objectIDs) {
[records addObject:[self.context objectWithID:objectID]];
}
}];

return records;
}
Expand Down Expand Up @@ -179,7 +187,7 @@ - (id)responseObjectForResponse:(NSURLResponse *)response

MMRecordResponse *recordResponse = [MMRecordResponse responseFromResponseObjectArray:responseArray
initialEntity:initialEntity
context:self.context
context:backgroundContext
options:options];

NSArray *records = [self recordsFromMMRecordResponse:recordResponse
Expand Down