(С++20) Fix VST module build

[RomanPudashkin]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 102e85fd-4d7e-41be-918b-0509dc09da06

📥 Commits

Reviewing files that changed from the base of the PR and between c6d1bb6 and 7e14654.

📒 Files selected for processing (1)

• framework/vst/sdk/CMakeLists.txt

---

📝 Walkthrough

Walkthrough

This PR adds an MSVC-specific compiler configuration to the VST SDK CMake build. Lines 188–193 introduce a conditional block that appends the /Zc:char8_t- compiler flag to the vst3sdk target when building with MSVC. This disables the C++20 change in which u8"" string literals are typed as char8_t arrays instead of char arrays, allowing the VST SDK's module_win32.cpp to remain compatible with code expecting std::string parameters.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is missing entirely. The template requires sections including issue resolution, motivation, and CLA/checklist completion.	Add a complete PR description following the template: include issue reference, motivation for the changes, and complete the required checklists.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: fixing a VST module build issue related to C++20, which matches the file changes and AI-generated summary.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}