Skip to content

Fix incorrect use of operator[] in removeStringTunings and removeHarp…#32522

Merged
Eism merged 2 commits intomusescore:masterfrom
CubikingChill:fix-removeStringTunings-bug
Mar 9, 2026
Merged

Fix incorrect use of operator[] in removeStringTunings and removeHarp…#32522
Eism merged 2 commits intomusescore:masterfrom
CubikingChill:fix-removeStringTunings-bug

Conversation

@CubikingChill
Copy link
Copy Markdown
Contributor

@CubikingChill CubikingChill commented Mar 6, 2026

Resolves: #32523

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@RomanPudashkin RomanPudashkin requested a review from Eism March 6, 2026 09:36
@Eism Eism merged commit 51657f6 into musescore:master Mar 9, 2026
12 of 13 checks passed
@CubikingChill CubikingChill deleted the fix-removeStringTunings-bug branch March 9, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect use of std::map::operator[] in Part::removeStringTunings() and Part::removeHarpDiagram() inserts unintended entries

2 participants