Skip to content

[MusicXML] split words and symbols#32512

Merged
miiizen merged 3 commits intomusescore:masterfrom
rettinghaus:xml/coda
Mar 19, 2026
Merged

[MusicXML] split words and symbols#32512
miiizen merged 3 commits intomusescore:masterfrom
rettinghaus:xml/coda

Conversation

@rettinghaus
Copy link
Copy Markdown
Contributor

This fixes export of text mixed symbols to corretcly encode symbols as symbol.

@RomanPudashkin RomanPudashkin requested a review from miiizen March 6, 2026 08:14
@miiizen
Copy link
Copy Markdown
Contributor

miiizen commented Mar 11, 2026

This looks good, we should use it for all words within a <direction-type> though

@rettinghaus
Copy link
Copy Markdown
Contributor Author

I'm a bit hesitent, because text formatting doesn't work here:

Bildschirmfoto 2026-03-12 um 14 29 46

With this solution the first case gives the expected result:

        <direction-type>
          <words>To</words>
          <symbol>coda</symbol>
          </direction-type>

But when you change the font the result keeps the xml formatting:

        <direction-type>
          <words>&lt;font size=&quot;12&quot;/&gt;&lt;font face=&quot;Didot&quot;/&gt;To</words>
          <symbol>coda</symbol>
          </direction-type>

The existing function returns this:

        <direction-type>
          <words font-family="FreeSerif">Standard </words>
          <words font-family="Leland Text"></words>
          </direction-type>

Ideally we would combine the two approaches, but for now I wouldn't touch the existing implementation.

@miiizen miiizen merged commit 52408cf into musescore:master Mar 19, 2026
12 checks passed
@github-project-automation github-project-automation bot moved this to Needs porting in MuseScore Studio 4.7 Mar 19, 2026
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 19, 2026
@Jojo-Schmitz
Copy link
Copy Markdown
Contributor

Jojo-Schmitz commented Mar 19, 2026

Backport to 4.7 in #32685

@rettinghaus rettinghaus deleted the xml/coda branch March 19, 2026 10:31
@RomanPudashkin RomanPudashkin moved this from Needs porting to Done in MuseScore Studio 4.7 Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants