Bind compression/decompression context to thread-local data for reuse#8
Open
polvorin wants to merge 2 commits intomururu:masterfrom
Open
Bind compression/decompression context to thread-local data for reuse#8polvorin wants to merge 2 commits intomururu:masterfrom
polvorin wants to merge 2 commits intomururu:masterfrom
Conversation
added 2 commits
August 10, 2020 11:31
Simple, never deallocate, don't support reload, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to reuse the contexts between nif calls, having a noticeable impact on perf.
See
https://facebook.github.io/zstd/zstd_manual.html#Chapter4
The PR is not very polished (it will never deallocate the context, on nif reload for example). Altough we are using it as we don't need live nif upgrade.
Would you be ok on merging this if it where completed?.