Review PR #93: Expand IBAN test coverage#94
Merged
strider2038 merged 1 commit intoApr 5, 2026
Merged
Conversation
… digits, mixed whitespace Co-authored-by: Igor Lazarev <strider2038@yandex.ru>
strider2038
merged commit 82a0e6f
into
cursor/-bc-e62609c4-def9-4060-92ba-c9980b5fd54d-526f
strider2038
added a commit
that referenced
this pull request
Apr 5, 2026
* Add IBAN validation (it, validate, is, translations) - validate.IBAN with mod-97 check and Symfony 7.2 country patterns - it.IsIBAN, is.IBAN, ErrInvalidIBAN, EN/RU messages - Tests and examples; changelog entry Co-authored-by: Igor Lazarev <strider2038@yandex.ru> * Expand IBAN unit tests (edge cases and more countries) - Named subtests; valid samples for BE, AT, IT, SE - Canonicalization: only spaces/NBSP, too short, bad UTF-8 prefixes - Reject: non-alpha country, non-numeric check digits, BBAN vs pattern, tab Co-authored-by: Igor Lazarev <strider2038@yandex.ru> * test(validate): extend IBAN cases for BR, MU, SC patterns - Valid samples exercising Symfony regex branches (trailing letters, long BBAN) - Negative: BR with correct length/pattern but failing mod-97; SC wrong total length; MU bank code width Co-authored-by: Igor Lazarev <strider2038@yandex.ru> * test(validate): expand IBAN coverage with territory aliases, boundary digits, mixed whitespace (#94) Co-authored-by: Cursor Agent <cursoragent@cursor.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review of PR #93 (Add IBAN validation constraint) with expanded test coverage for
validate.IBAN.Tests added
\xe2alone.Coverage
validate/iban.gofunctions remain at 100% on all reachable paths. Two internal helpers (isAlpha266.7%,ibanExpandedNumeric/ibanMod97~90%) have unreachable defensive branches due to prior validation steps — this is expected and correct.See the review comment on PR #93 for the full analysis.