[fix] Issues with composer and enhanced makefile#22
[fix] Issues with composer and enhanced makefile#22jorgemuza wants to merge 1 commit intomunza:mainfrom
Conversation
-Fix small typos in README file -Enhanced docker file to copy composer on app container -Enhanced makefile to remove orphans and volumes
|
|
||
| WORKDIR /var/www/html | ||
|
|
||
| COPY --from=vendor /usr/bin/composer /usr/bin/composer |
There was a problem hiding this comment.
@jorgemuza Thanks for the PR 😄
The composer executable was intentionally not copied in the image. The image is intended to be used as a production image and don't require composer. We can use make composer to start an sh session with composer command available.
If there is a need for composer command to be available in prod environment then it can be added additionally and not copied by default.
I would suggest to either not copy it in the image or at least comment it out and add a note above so it can be used if necessary. Eg.
# Notes about not having it in the image...
# COPY --from=vendor /usr/bin/composer /usr/bin/composer
|
Loved the changes in the |
| @docker-compose down -v | ||
|
|
||
| clean: ## Clean all Docker services | ||
| @docker rmi -f lumen-api-starter-app |
There was a problem hiding this comment.
Removing volumes with -v is risky. Developer may not want to delete the volumes when they want to remove only the instances with down command.
I will suggest the following instead -
down: ## Down all Docker services
@docker-compose down
remove: ## Remove all Docker instances, images, volumes and networks
@docker-compose down -v
@docker rmi -f lumen-api-starter-app
-Fix small typos in README file
-Enhanced docker file to copy composer on app container
-Enhanced makefile to remove orphans and volumes