Connection returns an empty data table when some fields are NULL (since data.table 1.15.0)#164
Open
gregleleu wants to merge 1 commit intomunterfi:masterfrom
Open
Connection returns an empty data table when some fields are NULL (since data.table 1.15.0)#164gregleleu wants to merge 1 commit intomunterfi:masterfrom
gregleleu wants to merge 1 commit intomunterfi:masterfrom
Conversation
- Fix NULL not handled by data.table anymore
Owner
|
Hi @gregleleu, thanks for reporting. Can you post a reproducible example, where this error occurs? In the tests everything seems to work fine with data.table version 1.15.2. Thanks! |
Author
|
Sure: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data.table no longer fills in rows with NA when some of the values are NULL since 1.15.0.
This broke connection:
This pull fixes that by recreating the rlang operator %||% and using it to avoid nulls.
Maybe not exactly your philosophy, and maybe needs to be replicated in other places, but a first step towards resolution :)