-
Notifications
You must be signed in to change notification settings - Fork 107
sc-meta - build error fixes #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Contract comparison - from 5fb0bf2 to 496204d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a meta build failure-handling bug when --locked is used, adds a regression test for that behavior, and refactors contract target name normalization into a dedicated constructor.
Changes:
- Propagate
cargobuild failures correctly in wasm contract builds (instead of silently continuing onJobFailed). - Add/update template tests, including a new
--lockedregression test and refactor test setup helpers. - Centralize contract name kebab-case normalization in
ContractCreatorTarget::new()and update call sites accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| framework/meta/tests/template_test.rs | Refactors template test helpers, adds --locked regression test, and updates build/test invocation helpers. |
| framework/meta/src/cmd/template/contract_creator_target.rs | Introduces ContractCreatorTarget::new() to kebab-case contract names in one place. |
| framework/meta/src/cmd/template/contract_creator.rs | Switches target construction to use ContractCreatorTarget::new(). |
| framework/meta-lib/src/contract/sc_config/wasm_build.rs | Fixes error propagation so --locked failures actually fail the meta build. |
| .github/workflows/actions.yml | Pins report workflow to a specific commit SHA pending a release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The meta build was not properly failing when the --locked flag was causing a failure.
Also added a test of this behavior, and improved the error messages.