Redux store action names #1712

arhtudormorar · 2026-01-19T13:45:30Z

added missing action names

gemini-code-assist · 2026-01-19T13:45:47Z

Summary of Changes

Hello @arhtudormorar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the consistency and clarity of Redux action dispatches throughout the application. By explicitly defining action objects with both a type and a payload for various store updates, the changes aim to improve the predictability and debuggability of state management operations. This refactoring ensures a uniform pattern for how actions are named and how their associated data is passed, contributing to a more robust and maintainable Redux store implementation.

Highlights

Redux Action Standardization: Standardized the dispatching of Redux actions by ensuring all getStore().setState calls explicitly use an action object with type and payload properties, replacing previous string-based or partial object dispatches.
Version Update: The package version has been incremented from 5.6.3 to 5.6.4 in package.json and reflected in CHANGELOG.md.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds action names and payloads to several Redux (Zustand) store actions, which is a great improvement for debugging with devtools. However, the implementation introduces multiple // @ts-ignore comments to bypass TypeScript errors. This is a significant concern as it compromises type safety. My review focuses on highlighting this issue and recommending that the underlying type definitions for the store be fixed instead of suppressing the errors. Addressing this will improve the overall maintainability and robustness of the codebase.

gemini-code-assist · 2026-01-19T13:48:26Z

src/store/actions/cache/cacheActions.ts

-    'clearCache'
+    {
+      type: 'clearCache',
+      // @ts-ignore


The use of // @ts-ignore is highly discouraged as it suppresses TypeScript errors and can hide actual bugs. The fact that it's needed here suggests that the type of the action object passed to setState is not correctly defined to include a payload property. Instead of ignoring the error, the underlying type definition for the Zustand store's setState method (when using devtools) should be corrected to allow for action objects with payloads. This would provide better type safety across the application.

gemini-code-assist · 2026-01-19T13:48:26Z

src/store/actions/config/configActions.ts

    {
-      type: 'setIsSigningUiEnabled'
+      type: 'setIsSigningUiEnabled',
+      // @ts-ignore


The use of // @ts-ignore is highly discouraged as it suppresses TypeScript errors and can hide actual bugs. The fact that it's needed here suggests that the type of the action object passed to setState is not correctly defined to include a payload property. Instead of ignoring the error, the underlying type definition for the Zustand store's setState method (when using devtools) should be corrected to allow for action objects with payloads. This would provide better type safety across the application.

gemini-code-assist · 2026-01-19T13:48:26Z

src/store/actions/sharedActions/sharedActions.ts

+export const logoutAction = () =>
+  getStore().setState(resetStore, false, {
+    type: 'logoutAction',
+    // @ts-ignore


The use of // @ts-ignore is highly discouraged as it suppresses TypeScript errors and can hide actual bugs. The fact that it's needed here suggests that the type of the action object passed to setState is not correctly defined to include a payload property. Instead of ignoring the error, the underlying type definition for the Zustand store's setState method (when using devtools) should be corrected to allow for action objects with payloads. This would provide better type safety across the application.

gemini-code-assist · 2026-01-19T13:48:26Z

src/store/actions/toasts/toastsActions.ts

+    false,
+    {
+      type: 'removeAllTransactionToasts',
+      // @ts-ignore


The use of // @ts-ignore is highly discouraged as it suppresses TypeScript errors and can hide actual bugs. The fact that it's needed here suggests that the type of the action object passed to setState is not correctly defined to include a payload property. Instead of ignoring the error, the underlying type definition for the Zustand store's setState method (when using devtools) should be corrected to allow for action objects with payloads. This would provide better type safety across the application.

gemini-code-assist · 2026-01-19T13:48:26Z

src/store/actions/toasts/toastsActions.ts

-    'addTransactionToast'
+    {
+      type: 'addTransactionToast',
+      // @ts-ignore


The use of // @ts-ignore is highly discouraged as it suppresses TypeScript errors and can hide actual bugs. The fact that it's needed here suggests that the type of the action object passed to setState is not correctly defined to include a payload property. Instead of ignoring the error, the underlying type definition for the Zustand store's setState method (when using devtools) should be corrected to allow for action objects with payloads. This would provide better type safety across the application.

gemini-code-assist · 2026-01-19T13:48:26Z

src/store/actions/toasts/toastsActions.ts

-    'removeTransactionToast'
+    {
+      type: 'removeTransactionToast',
+      // @ts-ignore


The use of // @ts-ignore is highly discouraged as it suppresses TypeScript errors and can hide actual bugs. The fact that it's needed here suggests that the type of the action object passed to setState is not correctly defined to include a payload property. Instead of ignoring the error, the underlying type definition for the Zustand store's setState method (when using devtools) should be corrected to allow for action objects with payloads. This would provide better type safety across the application.

gemini-code-assist · 2026-01-19T13:48:26Z

src/store/actions/toasts/toastsActions.ts

-      'createCustomToast'
+      {
+        type: 'createCustomToast',
+        // @ts-ignore


The use of // @ts-ignore is highly discouraged as it suppresses TypeScript errors and can hide actual bugs. The fact that it's needed here suggests that the type of the action object passed to setState is not correctly defined to include a payload property. Instead of ignoring the error, the underlying type definition for the Zustand store's setState method (when using devtools) should be corrected to allow for action objects with payloads. This would provide better type safety across the application.

gemini-code-assist · 2026-01-19T13:48:27Z

src/store/middleware/logoutMiddleware.ts

-    getStore().setState(resetStore);
+    getStore().setState(resetStore, false, {
+      type: 'logoutMiddleware',
+      // @ts-ignore


The use of // @ts-ignore is highly discouraged as it suppresses TypeScript errors and can hide actual bugs. The fact that it's needed here suggests that the type of the action object passed to setState is not correctly defined to include a payload property. Instead of ignoring the error, the underlying type definition for the Zustand store's setState method (when using devtools) should be corrected to allow for action objects with payloads. This would provide better type safety across the application.

* Expose walletConnect data (#1711) * Expose walletConnect data * Update changelog * Add shallow copy * Merge pull request #1712 from multiversx/tm/fix/redux-store-action-names Redux store action names --------- Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com>

arhtudormorar added 4 commits January 19, 2026 13:53

Refactor action creators to include payload structure for Redux actions

3f887ed

Update CHANGELOG

5074a53

Merge branch 'development' into tm/fix/redux-store-action-names

eaa67f4

5.6.4

cc21519

mgavrila approved these changes Jan 19, 2026

View reviewed changes

radumojic approved these changes Jan 19, 2026

View reviewed changes

arhtudormorar merged commit 7643dd3 into development Jan 19, 2026
2 checks passed

arhtudormorar deleted the tm/fix/redux-store-action-names branch January 19, 2026 13:47

gemini-code-assist bot reviewed Jan 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Redux store action names #1712

Redux store action names #1712

Uh oh!

arhtudormorar commented Jan 19, 2026

Uh oh!

gemini-code-assist bot commented Jan 19, 2026

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 19, 2026

Uh oh!

gemini-code-assist bot Jan 19, 2026

Uh oh!

gemini-code-assist bot Jan 19, 2026

Uh oh!

gemini-code-assist bot Jan 19, 2026

Uh oh!

gemini-code-assist bot Jan 19, 2026

Uh oh!

gemini-code-assist bot Jan 19, 2026

Uh oh!

gemini-code-assist bot Jan 19, 2026

Uh oh!

gemini-code-assist bot Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Redux store action names #1712

Redux store action names #1712

Uh oh!

Conversation

arhtudormorar commented Jan 19, 2026

Uh oh!

gemini-code-assist bot commented Jan 19, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants