fix: fix the misuse of unbuffered os.Signal channel #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnal.Notify Signed-off-by: fivecut <fivecut@126.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a concurrency issue related to signal handling in the proxy server's shutdown mechanism. The change addresses the misuse of an unbuffered channel with signal.Notify, which can cause signal delivery problems.
- Converts an unbuffered
os.Signalchannel to a buffered channel with capacity 1
|
|
||
| func waitForServerShutdown(httpServer *http.Server, closableComponents *data.ClosableComponentsHandler) { | ||
| quit := make(chan os.Signal) | ||
| quit := make(chan os.Signal, 1) |
There was a problem hiding this comment.
Good fix! Using a buffered channel with capacity 1 prevents potential signal loss. The Go documentation recommends buffered channels for signal.Notify to ensure signals are not dropped if the receiver is not immediately ready.
Suggested change
| quit := make(chan os.Signal, 1) | |
| quit := make(chan os.Signal, 1) // Buffered channel with capacity 1 to prevent signal loss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the misuse of unbuffered os.Signal channel as argument to signal.Notify