Reduce Database Connections#1606
Merged
Merged
Conversation
|
k6 load testing comparison.
Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
claudiulataretu
approved these changes
Jun 3, 2026
radumojic
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
PersistenceModule.forRoot()was previously imported across multiple feature modules, forcing TypeORM to repeatedly initialize separate MongoDB connection pools.Proposed Changes
.forRoot()imports from all individual feature modules to prevent multiple pool allocations.PersistenceModule.forRoot()exclusively within the main root module where the application is bootstrapped (listen).@Global()decorator on the module to seamlessly distribute database repositories andPersistenceServiceglobally across the app without breaking dependencies.queue.worker.module.tswhich is not used anywhereHow to test
mongoshusingdb.serverStatus().connections.