Fix processLineAgainstMesh crashes when checking for colored meshes
#4662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed crash in
processLineAgainstMeshwhen processing models with colored meshes (no texture coordinates). The function now safely handles models without UV data by using barycentric coordinates as a fallback.Fixes: #4632
Motivation
The function would crash with an access violation (0xC0000005) when called on certain models that only have vertex colors without texture coordinates (e.g., model IDs: 13656, 13606, 3081, 3060, 1784, 2070, 2077, 2122, 2742, 2772, 8146, 953, 1318, 2594, 2782, 2602, 2781).
Test plan
Test script: The attached resource spawns a test object at (0, 0, 3). You can change the model ID at the beginning of the script. (Shader won't apply on these object, thats a different issue)
process_test.zip
gta_sa_3erIIBjOun.mp4
Checklist