-
-
Notifications
You must be signed in to change notification settings - Fork 532
Skip antivirus warning when running under Wine #4536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qaisjp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement.
We have a helper here already:
mtasa-blue/Client/cefweb/CWebApp.cpp
Lines 24 to 29 in 1b4e5a2
| // Helper to detect Wine/Proton environment | |
| bool IsRunningOnWine() | |
| { | |
| HMODULE hNtdll = GetModuleHandle("ntdll.dll"); | |
| return hNtdll && GetProcAddress(hNtdll, "wine_get_version"); | |
| } |
Maybe you can move this code to a shared location so both projects can share the code
As i see you already did it, thanks. |
|
Huge thanks to both of you guys, that prompt was always super annoying! |
Closes #4459
This PR skips antivirus warnings when running under Wine.
(It needs to be tested, but based on my research, it should be fine.)