ci: build and publish riscv64 binaries in release workflow#81
Merged
Conversation
Signed-off-by: Cong Wang <cwang@multikernel.io>
Signed-off-by: Cong Wang <cwang@multikernel.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
v0.8.2 added riscv64 support, but no riscv64 binary appeared on the GitHub Release page.
The riscv64 build existed only in
ci.yml(rust-riscv64-cross), which runs on push/PR tomainas a compile-regression guard and never packages or uploads anything.release.yml(triggered byv*tags) only builtx86_64andaarch64, so the release assets never included riscv64.Fix
Add a
riscv64gc-unknown-linux-gnuentry to therelease.ymlbuild matrix:ubuntu-latest(no native riscv64 runner exists), reusing the cross-toolchain setup fromci.yml(gcc-riscv64-linux-gnuplus linker/CC env vars).CARGO_TARGET_*_LINKER/CC_*env var names from the target triple, so it generalizes to future cross targets.experimental: truewithcontinue-on-error, so an untested cross-build regression cannot block the x86_64/aarch64 release or the crates.io/PyPI publish.Caveats
workflow_dispatchor cut a new tag.