Add integration tests and align proto with RFC spec#27
Merged
ajit-zer07 merged 1 commit intomainfrom Apr 5, 2026
Merged
Conversation
Add three-tier integration test suite (47 gRPC protocol tests, 5 Rig agent tool tests, 3 E2E OpenAI tests) covering all modes, error paths, signals, dedup, cancel auth, and discovery. Align core.proto with RFC by promoting ParticipantActivity and SessionMetadata enrichment to the normative spec, and removing non-normative admin RPCs (GetRuntimeMetrics, GetSessionHistory) from the runtime. These operational features are served by the control plane from its own PostgreSQL data instead. Enable progress capability and WatchSignals ambient signal broadcast. Add participant activity tracking to sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolSet::call()#[ignore]): real OpenAI GPT-4o-mini agents coordinating through the runtimeproto/macp/v1/core.protowith RFC spec — zero diff between runtime and normative protoGetRuntimeMetrics,GetSessionHistory) and Prometheus HTTP endpoint from runtime; these are served by the control plane insteadParticipantActivitymessage and enrichSessionMetadatawith participant list and activity tracking (promoted to RFC spec)ProgressCapabilityandWatchSignalsambient signal broadcasthyper/hyper-util/http-body-utildependenciesProto changes (normative)
Added to RFC spec
core.proto:ParticipantActivity { participant_id, last_message_at_unix_ms, message_count }SessionMetadatafields 9-10:participants,participant_activityRemoved from runtime
core.proto(moved to control plane):GetRuntimeMetricsRequest/Response,ModeMetricsEntryGetSessionHistoryRequest/Response,HistoryEntryGetRuntimeMetricsandGetSessionHistoryRPCs fromMACPRuntimeServiceTest plan
cargo test— 301 unit/conformance tests passcargo clippy— no warningscargo build— clean build, no hyper/http-body-util depsdiff proto/macp/v1/core.proto ../multiagentcoordinationprotocol/schemas/proto/macp/v1/core.proto— zero differencesMACP_TEST_BINARY=../target/debug/macp-runtime cargo test -- --test-threads=1— 52 tests pass (47 Tier 1 + 5 Tier 2)OPENAI_API_KEYnpm run build— clean build