Skip to content

Add integration tests and align proto with RFC spec#27

Merged
ajit-zer07 merged 1 commit intomainfrom
add-integration-tests
Apr 5, 2026
Merged

Add integration tests and align proto with RFC spec#27
ajit-zer07 merged 1 commit intomainfrom
add-integration-tests

Conversation

@ajit-zer07
Copy link
Copy Markdown
Contributor

Summary

  • Add three-tier integration test suite exercising the runtime through the real gRPC boundary
    • Tier 1 (47 tests): scripted protocol tests for all modes, error paths, signals, version binding, dedup, cancel auth, discovery, streaming
    • Tier 2 (5 tests): Rig agent framework tools calling MACP operations via ToolSet::call()
    • Tier 3 (3 tests, #[ignore]): real OpenAI GPT-4o-mini agents coordinating through the runtime
  • Align proto/macp/v1/core.proto with RFC spec — zero diff between runtime and normative proto
  • Remove non-normative admin RPCs (GetRuntimeMetrics, GetSessionHistory) and Prometheus HTTP endpoint from runtime; these are served by the control plane instead
  • Add ParticipantActivity message and enrich SessionMetadata with participant list and activity tracking (promoted to RFC spec)
  • Enable ProgressCapability and WatchSignals ambient signal broadcast
  • Add participant activity tracking (per-sender message counts and last-seen timestamps) to sessions
  • Remove unused hyper/hyper-util/http-body-util dependencies

Proto changes (normative)

Added to RFC spec core.proto:

  • ParticipantActivity { participant_id, last_message_at_unix_ms, message_count }
  • SessionMetadata fields 9-10: participants, participant_activity

Removed from runtime core.proto (moved to control plane):

  • GetRuntimeMetricsRequest/Response, ModeMetricsEntry
  • GetSessionHistoryRequest/Response, HistoryEntry
  • GetRuntimeMetrics and GetSessionHistory RPCs from MACPRuntimeService

Test plan

  • cargo test — 301 unit/conformance tests pass
  • cargo clippy — no warnings
  • cargo build — clean build, no hyper/http-body-util deps
  • diff proto/macp/v1/core.proto ../multiagentcoordinationprotocol/schemas/proto/macp/v1/core.proto — zero differences
  • Integration tests: MACP_TEST_BINARY=../target/debug/macp-runtime cargo test -- --test-threads=1 — 52 tests pass (47 Tier 1 + 5 Tier 2)
  • Tier 3 E2E tests require OPENAI_API_KEY
  • Control plane npm run build — clean build

  Add three-tier integration test suite (47 gRPC protocol tests, 5 Rig
  agent tool tests, 3 E2E OpenAI tests) covering all modes, error paths,
  signals, dedup, cancel auth, and discovery.

  Align core.proto with RFC by promoting ParticipantActivity and
  SessionMetadata enrichment to the normative spec, and removing
  non-normative admin RPCs (GetRuntimeMetrics, GetSessionHistory) from
  the runtime. These operational features are served by the control
  plane from its own PostgreSQL data instead.

  Enable progress capability and WatchSignals ambient signal broadcast.
  Add participant activity tracking to sessions.
@ajit-zer07 ajit-zer07 merged commit ddb9790 into main Apr 5, 2026
11 checks passed
@ajit-zer07 ajit-zer07 deleted the add-integration-tests branch April 5, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant