Align control plane with MACP spec d31ffb1 and runtime 168ab31#4
Merged
ajit-zer07 merged 1 commit intomainfrom Mar 23, 2026
Merged
Align control plane with MACP spec d31ffb1 and runtime 168ab31#4ajit-zer07 merged 1 commit intomainfrom
ajit-zer07 merged 1 commit intomainfrom
Conversation
Remove SessionWatch/passive-attach reconnect path (spec forbids it), replace with getSession() polling fallback. Fix sender auth mismatch by setting empty sender on openSession() envelope. Add INVALID_SESSION_ID error code mapping (HTTP 400), instructions field from InitializeResponse, listChanged capability declaration, Contribute message type for ext.multi_round.v1 extension mode, and JSON decode fallback in proto registry for extension modes without proto definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Summary
now uses
getSession()polling with exponential backoff until terminal state. Recovery service passespollOnly: trueto skipthe stream path entirely.
openSession()now setssender: ''so the runtime fills it from the authenticated identity,preventing rejection of mismatched senders.
startSession()andsend()now map this runtime error code to HTTP 400 insteadof a blanket 502.
instructionsfield from InitializeResponse, advertiselistChanged: truefor modeRegistryand roots capabilities, log runtime instructions during execution.
Contributemessage type (used byext.multi_round.v1) maps toproposal.updatedin the eventnormalizer. Proto registry registers extension modes with
__json__sentinel for JSON decode fallback.Test plan
npx tsc --noEmit— TypeScript compiles cleannpx jest— all 253 tests pass across 20 suitesnpx eslint "src/**/*.ts"— 0 errors (pre-existing warnings only)getSession()polling (not SessionWatch)ext.multi_round.v1, verify Contribute events normalize correctly