refactor: collapse scanner boilerplate via runScanner + scanAll#79
Merged
Conversation
ffdbb09 to
8ba57c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefileso the verify chain runs with one command.Changes
src/utils.js— newrunScannerhelper (shared binary resolve → exec → parse, plus the permission/timeout warning contract). MovedgetCliOptionValue/hasCliFlag/optsOfhere (were duplicated acrossaudit.jsandupgrade.js).src/scanners/*— 32 exec-and-parse scanners reduced tocommand+parse. The 6 filesystem / multi-step scanners (cargo,dnf,go,gradle,maven,nuget) are intentionally left as-is — forcing them into the helper would hurt readability.src/index.js— extractscanAll/resolveScanners; adopted inaudit.jsandupgrade.js.src/upgrade.js— inline the trivial bucket summary.src/ports.js— drop a deadparseMacPortsregex branch.Makefile—make verify=format:check+lint+test.AGENTS.md/GEMINI.md— agent guides; ignore local.claudedir.chore(deps-dev): eslint 10.4.1 → 10.5.0, prettier 3.8.3 → 3.8.4.Test plan
make verify(format:check + lint + test) greennode --test— 12 tests passpkgmap,pkgmap -m npm,pkgmap audit -m npm --json,pkgmap ports --json,pkgmap upgrade -m npm --dry-runnpm run release:check