feat(cli): add configurable backend image fallback tags via CLI options#8811
Closed
localai-bot wants to merge 2 commits intomudler:masterfrom
Closed
feat(cli): add configurable backend image fallback tags via CLI options#8811localai-bot wants to merge 2 commits intomudler:masterfrom
localai-bot wants to merge 2 commits intomudler:masterfrom
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Add WebSocket route handling for /v1/responses and /responses endpoints - Add WebSocket message types to schema (ORWebSocketClientMessage, ORWebSocketServerEvent, etc.) - Add connection-local cache types for response storage - Implement initial WebSocket infrastructure (handler to be added in next commit)
- Add three new CLI flags: --backend-images-release-tag, --backend-images-branch-tag, --backend-dev-suffix - Add corresponding fields to SystemState for passing configuration - Add WithBackendImagesReleaseTag, WithBackendImagesBranchTag, WithBackendDevSuffix options - Modify getFallbackTagValues to use SystemState instead of environment variables - Pass CLI options through to SystemState in run.go Signed-off-by: localai-bot <localai-bot@example.com>
bb64ef4 to
cbcd8dc
Compare
Contributor
Author
|
PR has been rebased against upstream/master as requested. Force-pushed. Waiting for CI to complete checks. @mudler Please review the changes when ready. |
Contributor
Author
|
Automated PR monitoring: Reviewed PR status. CI checks are currently failing (DCO, build-test, image-build, tests). The branch is already up-to-date with upstream/master. Waiting for CI to complete. No code changes needed at this time. |
Contributor
Author
|
PR closed as requested. A clean version has been created at #8812 with only the relevant changes (configurable backend image fallback tags via CLI options). The original PR contained unrelated changes (WebSocket support) that were not part of the task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements configurable backend image fallback tags via CLI options as requested in the original PR #8674.
Changes
--backend-images-release-tag,--backend-images-branch-tag,--backend-dev-suffixWithBackendImagesReleaseTag,WithBackendImagesBranchTag,WithBackendDevSuffixgetFallbackTagValuesto read from SystemState instead of environment variablesUsage
Users can now configure fallback tag patterns via CLI:
Or via environment variables:
Signed-off-by: localai-bot localai-bot@example.com