refactor: migrate to Navigation 3 with connected composable overloads#600
Merged
mtrewartha merged 1 commit intomainfrom Mar 22, 2026
Merged
refactor: migrate to Navigation 3 with connected composable overloads#600mtrewartha merged 1 commit intomainfrom
mtrewartha merged 1 commit intomainfrom
Conversation
POS-27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NavDisplay,NavKey,entryProvider)LocationView,CompassView,SunView,SettingsView) that internally create their ViewModel, collect state, and provide CompositionLocals — decoupling the app module from feature internalscoordinatesFormatterhelper fromMainViewinto the location module asrememberCoordinatesFormatterin thelocalspackage, where it belongs alongsideLocalCoordinatesFormatterMainView.ktso each nav entry only passes navigation callbacks and app-level concerns (sharing intents, license/privacy URLs)locationEntries,compassEntries,sunEntries,settingsEntries)Test plan
./gradlew assembleDebug— compiles successfully./gradlew test— all tests pass🤖 Generated with Claude Code