Conversation
mtgto
force-pushed
the
filedict-mainactor
branch
from
8d49d01 to
cbf293e
Compare
Owner
Author
|
#452 に続く。このPRはクローズします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UserDictやFileDictでSwift Concurrency対応してSwift 6でコンパイルエラーになるという警告が出ないように修正します。
辞書の参照や単語の追加削除は基本的には
@MainActorにしていくだけなのですが、読み込みだけは時間がかかるため別スレッドでの実行を可能にする必要があります。そのためnonisolatedなメソッド
FileDict#loadを生やし、読み込み処理はそちらにもっていきます。nonisolatedなメソッド内でメンバ変数dictを設定する必要があり、そのためにasyncメソッドにしています。