Avoid leaking selected ice to runner when trash-like-cards is enabled#8731
Draft
najmam wants to merge 1 commit into
Draft
Avoid leaking selected ice to runner when trash-like-cards is enabled#8731najmam wants to merge 1 commit into
najmam wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not ready for merging, it just makes progress on issue #8729 by reproducing it in a failing test.
One way to make the test pass is to set
:waiting-prompt falseinstead oftruein game.core.installing/corp-install-pay, but I'm not sure it's the right fix, could be too heavy-handed. I didn't work out the consequences enough to assess that.Also note that the added test is filed under the existing one for Key Performance Indicators, however the bug is not specific to that card. Don't know if the test would be better placed elsewhere.
Not sure I'll have time to continue working on this so feel free to pick it up.