C++11 Conversion, Refactor and CMake conversion #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewPowley
commented
Apr 23, 2018
MatthewPowley
commented
- Conversion of the code to C++11.
- Changed parameter naming convention, removed 'a' prefix and used camel-case
- Whitespace and layout changes to make code more readable and aid debugging
- 'const' correctness changes to allow compilers to make better performance optimizatiobs
* Started converting the whole system to CMake for ease of multi-platform support and configuration (easier to locate required 3rd party libraries) * Added CppUnit GIT sub-module and CMake scripts to compile it under Windows * Added CMake scripts for configuring FOCAS2 for consumption by the Fanuc adapter
* Added or updated the copyright header block. * Removed Unicode characters * Converted to C++ style comments
* Use of 'auto' keyword * Use literal identifiers to prevent narrowing of types during compilation * Fixed truncation issue in a test
* C++ conversion using 'auto', 'nullptr' keywords * Use of std::vector as a container for items to simplify memory management * Use of std::chrono and std::thread for cross platform sleep functionality
* Added missing implementation methods * Removed local variable that was masking derived class member * Implemented missing pure virtual function in a derived class
* Removed 'allowDNC' functionality as this never worked * Fixed subtle bug when character buffers we not initialized correctly (show when NC had an alarm condition) * Added ability to connect to a NC using HSSB * Use of auto, nullptr keywords * Loop iteration improvements * Removed most 'printf' with 'std::cout' for improved reliability * const correctness changes
* The incorrect amount of memory was being allocated, replaced using std::vector to make memory management neater
…e as 'unavailable'
* Converted from raw pointers to std::unique_ptr
…Fanuc adapter * Use of std::vector for memory management
…nuc adapter * Use of std::vector for memory management
…nuc adapter * Used inline helper function for converting from signed binary format into a decimal value * Created references within loops to avoid multiple address lookups.
… for conversion of double data * Moved conversion function for signed binary to decimal into a helper header file * Modified Axis methods to use helper file * Changed a loop to perform less dereferencing
* Changed default configuration ini file to add sample values for Macro variables * Converted to std::unique_ptr for main adapter object to clean-up better if the process is ended
* Use of 'final' keyword to signify that a method should be an overload of a base class and that no classes can override its implementation * Made the line endings consistent
… with std::unique_ptr
* Replaced with inet_ntop (InetNtop on Windows) and hard-coded for IPv4 address lookup
* This is a header only ilibrary which builds upon <chrono>. It adds some new duration types, and new time_point types. It also adds "field" types such as year_month_day which is a struct {year, month, day}. And it provides convenient means to convert between the "field" types and the time_point types.
…/dates * Converted old integer timeout/period values to std::chrono::milliseconds * Use 'Date' library functions for converting a std::chrono::time_point into an ISO 8601 formatted string_buffer (now platform independent code)
* Typo in pre-processor definition prevented cleanup of sockets on Windows machines
* Clone URL is no longer accessible through HTTP, must be HTTPS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.