Update embedding function from sync to async with 0.6.37#5
Open
GlisseManTV wants to merge 2 commits into
Open
Conversation
… support - Replace synchronous embedding function call with async-aware wrapper - Add _call_embedding_function to handle both sync and async embedding functions - Update _detect_embedding_dimension to use async call with proper error handling - Improve embedding dimension detection with better type checking and error messages - Maintain backward compatibility with existing sync embedding functions This change enables compatibility with OpenWebUI 0.6.37+ where embedding functions are async, while preserving support for legacy sync functions through a threadpool fallback. The update ensures robustness and future-proofing of the memory system's embedding pipeline.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
OpenWebUI 0.6.37 changed EMBEDDING_FUNCTION from sync to async
The Memory System was still calling it synchronously, causing crashes
How?
Created a unified _call_embedding_function() wrapper that detects async/sync automatically
Made _detect_embedding_dimension() async-aware
Updated all embedding calls to use the new wrapper
Maintained backward compatibility with older versions
Result?
✅ Memory System works with OpenWebUI 0.6.37+
✅ Backward compatible with older versions
✅ Better error handling and logging
✅ No breaking changes for users