feat: init addon#1
Open
paoloricciuti wants to merge 2 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
jycouet
reviewed
Jun 4, 2026
| @@ -0,0 +1,42 @@ | |||
| { | |||
| "name": "@msw/sveltekit", | |||
There was a problem hiding this comment.
Suggested change
| "name": "@msw/sveltekit", | |
| "name": "@msw/sv", |
Like this you can do : npx add @msw if you keep your name you will have to do npx add @msw/sveltekit
Collaborator
Author
There was a problem hiding this comment.
Yeah we talked about it with @kettanaito but he prefers this as it's more explicit
Co-authored-by: jyc.dev <jycouet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This initialize the addon with the minimum amount of file touched. I've added test coverage both for a clean install AND for an install where the files where already there.
Right now I didn't add any workflow to run those test but it's easy to do in a future PR.