Skip to content

Conversation

@mulle-nat
Copy link

@mulle-nat mulle-nat commented Oct 28, 2025

The idea is that people with their own clang fork can specify their version and repository and get it build with llvm-mingw. This is a self serving patch request, because that's just what I needed. :)

@mstorsjo
Copy link
Owner

You can already set the LLVM version, e.g. as LLVM_VERSION=<foo> ./build-all.sh. It's not quite as well presented as an actual option, but it's also a kinda fringe usecase.

I'd be ok with switching the LLVM repo url to use the same pattern for default initialization if not set by the caller (see line 19 in build-llvm.sh), but I'm not sure if I'd want to add these extra explicit options for it.

@mulle-nat
Copy link
Author

Dude its not a biggy for me. Feel free to drop the pull request. I can live with a fork :)

@mstorsjo
Copy link
Owner

Dude its not a biggy for me. Feel free to drop the pull request. I can live with a fork :)

Well if we'd just keep LLVM_VERSION as it is, and add an LLVM_REPOSITORY variable in the same sense, we could totally merge this, and you wouldn't need to keep differences in this repo at least :-)

@mulle-nat
Copy link
Author

Sounds fine to me :)

@mulle-nat
Copy link
Author

I checked your current version but it still has the hardcoded, non-variable https://github.com/llvm/llvm-project.git. It would be nice, if you could change that.

@mstorsjo
Copy link
Owner

mstorsjo commented Dec 8, 2025

Done in 1ce1cf7 - I was kinda waiting for you to update this PR to do it. :-)

@mstorsjo mstorsjo closed this Dec 8, 2025
@mulle-nat
Copy link
Author

cool, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants