Skip to content

profiler: check paranoia level after trying SwCpuClock #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhizer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

profiler: check paranoia level after trying SwCpuClock #730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions samply/src/linux/profiler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,25 +394,6 @@ fn init_profiler(
attach_mode,
);

if let Err(error) = &perf {
if error.kind() == std::io::ErrorKind::PermissionDenied {
if let Some(level) = paranoia_level() {
if level > 1 {
eprintln!();
eprintln!(
"'/proc/sys/kernel/perf_event_paranoid' is currently set to {level}."
);
eprintln!("In order for samply to work with a non-root user, this level needs");
eprintln!("to be set to 1 or lower.");
eprintln!("You can execute the following command and then try again:");
eprintln!(" echo '-1' | sudo tee /proc/sys/kernel/perf_event_paranoid");
eprintln!();
std::process::exit(1);
}
}
}
}

let mut perf = match perf {
Ok(perf) => perf,
Err(_) => {
Expand All @@ -434,6 +415,25 @@ fn init_profiler(
Ok(perf) => perf, // Success!
Err(error) => {
eprintln!("Failed to start profiling: {error}");
if error.kind() == std::io::ErrorKind::PermissionDenied {
if let Some(level) = paranoia_level() {
if level > 1 {
eprintln!();
eprintln!(
"'/proc/sys/kernel/perf_event_paranoid' is currently set to {level}."
);
eprintln!("In order for samply to work with a non-root user, this level needs");
eprintln!("to be set to 1 or lower.");
eprintln!(
"You can execute the following command and then try again:"
);
eprintln!(
" echo '-1' | sudo tee /proc/sys/kernel/perf_event_paranoid"
);
eprintln!();
}
}
}
std::process::exit(1);
}
}
Expand Down