Skip to content

Conversation

@paulpfeiffer1988
Copy link

WiFiControl.scanForWiFi( function(err, response) {
    if (err) console.log(error);
    console.log(response);
  });

Doesn´t find any wlan.
I have fixed it in my fork, so that it is working for me.

@msolters
Copy link
Owner

Hi Paul, and thank you for your time.

However, any edits must be made to https://github.com/msolters/wifi-control-node/blob/master/src/wifi-control.coffee and compiled to the .js target. Do not edit the .js directly as it will be overwritten by later edits or contributions.

@msolters
Copy link
Owner

I believe the changes you are interested in making begin here

@paulpfeiffer1988
Copy link
Author

Hey thanks i will have a look at this tomorrow.

But again, please could you tell me what is your license?

2015-12-11 15:13 GMT+01:00 Mark Solters notifications@github.com:

I believe the changes you are interested in making begin here
https://github.com/msolters/wifi-control-node/blob/master/src/wifi-control.coffee#L318


Reply to this email directly or view it on GitHub
#7 (comment)
.

@msolters
Copy link
Owner

ATP there is no license defined. Provided its dependencies though, I think that it should be MIT.

@paulpfeiffer1988
Copy link
Author

Hey
ok thats fine.
thank you.

2015-12-11 17:26 GMT+01:00 Mark Solters notifications@github.com:

ATP there is no license defined. Provided its dependencies though, I think
that it should be MIT.


Reply to this email directly or view it on GitHub
#7 (comment)
.

@paulpfeiffer1988
Copy link
Author

Hi. Today I had time to test the other functions of your project on Ubuntu
14.04 and there are even more problems . In addition , I read you've tested
the code on Ubuntu 15.04 ? Perhaps nmcli is generally different in the two
versions of Ubuntu? How should we proceed?

2015-12-11 17:43 GMT+01:00 Paul Pfeiffer paulpfeiffer1988@googlemail.com:

Hey
ok thats fine.
thank you.

2015-12-11 17:26 GMT+01:00 Mark Solters notifications@github.com:

ATP there is no license defined. Provided its dependencies though, I
think that it should be MIT.


Reply to this email directly or view it on GitHub
#7 (comment)
.

@msolters
Copy link
Owner

Well I think the best way would be to create an issue for each problem you encounter. We are relying on a precise formatting when we parse nmcli so its quite easy to break or fool by changing the results just a bit.

@msolters
Copy link
Owner

I think that at this point what would make the most sense is to migrate from nmcli to the iw tool. This would only affect linux, and I think it would produce more stable results from distro to distro.

@cmaissan
Copy link

FYI - I've created a fork and updated the Linux script to work with nmcli 0.9.8.8 on Ubuntu 14.04.

Let me know if there's anything I can do to help bring this into the project. Perhaps two separate OS specific scripts selected based on the nmcli version?

@msolters
Copy link
Owner

msolters commented Jul 2, 2016

Hey @cmaissan I'm sure you have already a working solution for yourself, but I wonder if you might be bothered to try a different type of solution. I replaced almost all of the nmcli logic with iw, iwconfig and ifconfig. You can try it out in PR #16 . I'm not sure if it will fix the 14.04 issues, but that's why I'm asking for testers!

@cmaissan
Copy link

Hi @msolter. Thanks, we will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants