Harden SSRF guard against redirect, IPv6-mapped, and alt-encoding byp…#42
Open
skull463 wants to merge 1 commit into
Open
Harden SSRF guard against redirect, IPv6-mapped, and alt-encoding byp…#42skull463 wants to merge 1 commit into
skull463 wants to merge 1 commit into
Conversation
…asses Follow-up to 60c029f (which fixed mskayyali#14's reported fda.gov case). - Re-validate every hop in fetchUrlMeta (redirect: manual, MAX_HOPS=5) so a public URL cannot 302 to http://169.254.169.254/ etc. - Parse IPv4 literals in all Node-accepted forms (dotted-decimal, dotted-octal, dotted-hex, packed integer, short forms) so http://2130706433/ and http://0x7f.0.0.1/ are blocked. - Unwrap IPv4-mapped/compatible IPv6 (::ffff:127.0.0.1) and apply IPv4 rules so loopback/metadata/RFC1918 cannot be reached via IPv6 syntax. - Block the IPv6 unspecified address ::. - Strip trailing dots during hostname normalization so 'localhost.' cannot bypass the named-host check. The mskayyali#14 fix (fc/fd prefix checks only on IPv6 literals) is preserved. No new dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…asses
Follow-up to 60c029f (which fixed #14's reported fda.gov case).
The #14 fix (fc/fd prefix checks only on IPv6 literals) is preserved. No new dependencies.