fix: resolve 4 open issues — SECURITY.md artifact, YAML quoting, hidden Unicode, hardcoded credentials#548
Open
okokkoko4414 wants to merge 6 commits into
Open
fix: resolve 4 open issues — SECURITY.md artifact, YAML quoting, hidden Unicode, hardcoded credentials#548okokkoko4414 wants to merge 6 commits into
okokkoko4414 wants to merge 6 commits into
Conversation
…en Unicode, hardcoded credentials - Remove stray EOFcat heredoc artifact from SECURITY.md (fixes msitarzewski#530) - Quote zk-steward description to fix YAML colon parsing (fixes msitarzewski#473) - Strip hidden Unicode soft hyphens from mobile-app-builder and app-store-optimizer headings (fixes msitarzewski#478) - Replace hardcoded passwords with process.env.TEST_PASSWORD (fixes msitarzewski#477) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses several repository hygiene/security issues in Markdown-based agent/testing templates (security policy rendering, YAML frontmatter validity, hidden Unicode removal, and credential handling in examples).
Changes:
- Removed a stray
EOFcat SECURITY.mdartifact fromSECURITY.md. - Fixed YAML frontmatter parsing by quoting
descriptioninspecialized/zk-steward.md. - Removed hidden Unicode soft-hyphen characters from headings in two agent markdown files.
- Replaced hardcoded example passwords with
process.env.TEST_PASSWORDin two testing templates.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
SECURITY.md |
Removes an accidental trailing heredoc artifact. |
specialized/zk-steward.md |
Quotes YAML description to avoid colon parsing errors. |
marketing/marketing-app-store-optimizer.md |
Strips hidden soft hyphen from a heading. |
engineering/engineering-mobile-app-builder.md |
Strips hidden soft hyphen from a heading. |
testing/testing-api-tester.md |
Replaces hardcoded password with env var in example request body. |
testing/testing-performance-benchmarker.md |
Replaces hardcoded password with env var in k6 example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
90
to
94
| // Test critical user journey | ||
| const loginResponse = http.post(`${baseUrl}/api/auth/login`, { | ||
| email: 'test@example.com', | ||
| password: 'password123' | ||
| password: process.env.TEST_PASSWORD | ||
| }); |
Comment on lines
74
to
78
| headers: { 'Content-Type': 'application/json' }, | ||
| body: JSON.stringify({ | ||
| email: 'test@example.com', | ||
| password: 'secure_password' | ||
| password: process.env.TEST_PASSWORD | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EOFcat SECURITY.mdheredoc artifact from SECURITY.md (fixes stray EOFcat heredoc artifact at end of SECURITY.md #530)process.env.TEST_PASSWORDin api-tester and performance-benchmarker (fixes [Security] Hardcoded credentials in api-tester and performance-benchmarker agents #477)Changes
6 files changed, 5 insertions(+), 6 deletions(-)
Test plan
🤖 Generated with Claude Code