Skip to content

refactor: Use cl-defmethod instead of deprecated defmethod #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dwilkins wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: Use cl-defmethod instead of deprecated defmethod #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9cc802
refactor: Use cl-defmethod instead of deprecated defmethod
dwilkins Jul 5, 2025
4be2a4d
Removed unneeded require of `eieio-compat`
dwilkins Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fxrd-validators.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
;;; We need lexical-binding so we can create closures.

(require 'eieio-base)
(require 'eieio-compat)
(require 's)
(require 'cl-lib)

(defclass fxrd-validator (eieio-named)
(;; Public slots
Expand Down Expand Up @@ -50,7 +50,7 @@
(regex :initform "^.*$"
:documentation "Regex to validate field against"))
"The base validator class for all field validation types")
(defmethod fxrd-validate (val field)
(cl-defmethod fxrd-validate (val field)
"Validate the field with the given validator"
(fxrd-general-validator val field))

Expand Down Expand Up @@ -97,7 +97,7 @@ specialized if necessary."
(comp-transform :initform #'string-to-number)
(regex :initform "[[:digit:]]*"))
"Integer fields")
(defmethod fxrd-validate :after ((val fxrd-numeric-v) field-value)
(cl-defmethod fxrd-validate :after ((val fxrd-numeric-v) field-value)
(let ((value (funcall (slot-value val 'comp-transform) field-value))
(min (slot-value val 'min))
(max (slot-value val 'max)))
Expand Down