Skip to content

The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed in php 8.6 (master) #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k0d3r1s wants to merge 1 commit into
base: master
Choose a base branch
from
Open

The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed in php 8.6 (master) #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion msgpack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ PHP_MSGPACK_API int php_msgpack_unserialize(zval *return_value, char *str, size_
default:
MSGPACK_WARNING("[msgpack] (%s) Unknown result", __FUNCTION__);
}
zval_dtor(return_value);
zval_ptr_dtor_nogc(return_value);
msgpack_unserialize_var_destroy(&mp.user.var_hash, 1);
RETVAL_FALSE;
return FAILURE;
Expand Down
2 changes: 1 addition & 1 deletion msgpack_unpack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ static zend_class_entry* msgpack_unserialize_class(zval **container, zend_string
}
}
ZEND_HASH_FOREACH_END();
zval_dtor(&container_tmp);
zval_ptr_dtor_nogc(&container_tmp);
}

}
Expand Down