This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Added support for Regex to determinate a data url#344
Open
sveneberth wants to merge 1 commit intomsaktype:masterfrom
Open
Added support for Regex to determinate a data url#344sveneberth wants to merge 1 commit intomsaktype:masterfrom
sveneberth wants to merge 1 commit intomsaktype:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a problem with SVGs in data-urls.
After formatting stylefmt return this:
A space is added after the comma, but this is an incorrect syntax (see RFC2397).
The reason for this incorrect syntax is that stylefmt expects data-urls encoded as base64, but this is still not required by the rfc.
Therefore I removed the base64 part in the regex to allow data ASCII data as well. The data: must be enough as indicator.
Of course we can match the base64 in the regex but this only a test and therefor I reduced it as far as possible.
Alternative would be: