Update install-linux.sh to match the new plugin build procedure#90
Open
AnClark wants to merge 1 commit intomruby-zest:masterfrom
Open
Update install-linux.sh to match the new plugin build procedure#90AnClark wants to merge 1 commit intomruby-zest:masterfrom
AnClark wants to merge 1 commit intomruby-zest:masterfrom
Conversation
ZynAddSubFX now use DPF's CMake module for plugin build, which brings the two new plugin formats: VST3, CLAP. This patch will install VST3 and CLAP plugins in addition.
fundamental
reviewed
Feb 10, 2023
| echo "" | ||
| echo "Thank you for supporting Zyn-Fusion" | ||
| echo "You can now use the 3.0.3 release via a LV2/VST plugin host or" | ||
| echo "You can now use the 3.0.3 release via a LV2/VST/VST3/CLAP plugin host or" |
Member
There was a problem hiding this comment.
Note to self, I really have to remember to update this version number :p The rest of the changes look reasonable to me.
Contributor
Author
There was a problem hiding this comment.
It's better to have a function for fetching version number.
Member
|
Good to merge conditioned on zynaddsubfx/zynaddsubfx#221 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch corresponds with my rewrite of plugin build procedure in ZynAddSubFX#221.
NOTICE: Currently untested.