Development branch

[marahmbawwab]

No description provided.

[pgervais]

calc_cursor_y is not defined in util.rb:EditRegion, which makes the UI crash as soon as you try typing something in the widget.

Have you committed all your changes?

[marahmbawwab]

Hi @pgervais,
I added another commit to solve this issue and now it should work properly.

[pgervais]

Thanks. Now the code runs. I played with the new behavior: cursor movement works fine. Left and right arrows correctly move it and it's displayed in the correct place.
There are a few issues though:

1. On initial display the widget is blank. You need to insert or delete a character for anything to show.
   How to reproduce:

• start the UI
• go to part settings: the 'name' and 'comment' fields are blank. I expect them to show their initial values.
• click in the 'name' field: a blinking cursor appears, but there is still no text.
• press a letter key (for ex. 't'): some text appears in addition to the letter just inserted.

2. Pressing the 'enter' key creates a new line. The solution here is to catch this keypress in onKey and simply return without doing anything.

3. The behavior under Kits > Kit Name is incorrect.
   Previous behavior: all blank kit names (all of them by default) show an ellipsis (three dots: "..."). These ellipsis disappear as soon as one character is entered and reappears when all characters are deleted.
   New (incorrect) behavior: all kit names show "kit name" instead of an ellipsis if they're blank or their initial value otherwise. When all characters are deleted the field stays blank.
   This new behavior is related to the code here

   mruby-zest-build/src/mruby-zest/example/TextLine.qml

   Line 47 in a581036

   l = label.empty? ? "..." : label.clone

   that is now ignored.

[pgervais]

I only did a quick pass over the details of the code because there will likely be more changes after you've fixed the remaining bugs I mentioned in my general comment.

[pgervais]

cursor_row instead of cursorrow

• it's the same as in @edit.cursor_row, which reduces the mental load (we don't have to think whether to spell it one way or another)
• using snake case seems standard in Ruby: https://namingconvention.org/ruby/

[pgervais]

This line disappeared with your change, and it's important. This is how TextLine ignores most of the non-printable characters.

[marahmbawwab]

Hi @pgervais ,
This line is the same as self.label = ll[0...-1], because of that I removed it and tried to replace my line with the previous line and the result was the same.

[pgervais]

Just to double check we're talking about the same thing. I was referring to the "elsif k.ord >= 32" line. Is that what you meant?

[fundamental]

Possibly an off-topic comment, but make sure to use a581036 in your branch if you're experiencing problems with creating shorter strings.

[marahmbawwab]

Hi Phillip,
No, I mean the self.label line, but I used the else instead of this line (elsif k.ord >= 32) but I realized that in the else I include the case where k.ord between 8 and 32, so I think I need to modify it as you say, what do you think?

[pgervais]

You can implement it the way you prefer. What is most important is to make sure values of k.ord less than 32 are ignored (with the exception of 8)

[marahmbawwab]

Thanks. Now the code runs. I played with the new behavior: cursor movement works fine. Left and right arrows correctly move it and it's displayed in the correct place. There are a few issues though:

1. On initial display the widget is blank. You need to insert or delete a character for anything to show.
   How to reproduce:

• start the UI
• go to part settings: the 'name' and 'comment' fields are blank. I expect them to show their initial values.
• click in the 'name' field: a blinking cursor appears, but there is still no text.
• press a letter key (for ex. 't'): some text appears in addition to the letter just inserted.

2. Pressing the 'enter' key creates a new line. The solution here is to catch this keypress in onKey and simply return without doing anything.
3. The behavior under Kits > Kit Name is incorrect.
   Previous behavior: all blank kit names (all of them by default) show an ellipsis (three dots: "..."). These ellipsis disappear as soon as one character is entered and reappears when all characters are deleted.
   New (incorrect) behavior: all kit names show "kit name" instead of an ellipsis if they're blank or their initial value otherwise. When all characters are deleted the field stays blank.
   This new behavior is related to the code here

   mruby-zest-build/src/mruby-zest/example/TextLine.qml

   Line 47 in a581036

   l = label.empty? ? "..." : label.clone

   
   that is now ignored.
   Hi @pgervais ,
   For your comment here, the first comment the behavior is different than what you say on my side --> when I ran it the initial value displayed.
   Note on the second point I am trying to find where the value of which key is pressed (enter) in order to do nothing in this case.
   and for the third point you mean that ... should be displayed when the text_field is blank instead if nothing ?

[pgervais]

Answering in order:

• if the behavior is different for you and for me there is likely a difference between or setups, or we're comparing different versions of the code. This is better tackled interactively on a video call, I'll reach out to you to set that up.
• the value for return is likely to be 13, but you need to check that. You can simply print the value of k.ord and see what is displayed when you press return.
• yes, I meant that "..." should be displayed instead of nothing when self.label is empty (and the cursor at the beginning).

[pgervais]

Sending some screenshots to illustrate points 1 and 3 I made above:

Initial display for "Part settings":

Correct display (before this PR):

Incorrect display (this PR, on my machine):

Initial display for "Kits":

Correct display (before this PR):

Incorrect display (this PR, on my machine):