Open
Conversation
- Update faraday dependency from < 2.0 to < 3.0 - Remove faraday_middleware dependency (incompatible with Faraday 2.x) - Replace Faraday.default_adapter with explicit :net_http adapter - Update specs to test for :net_http adapter The :json response middleware is now built into Faraday 2.x, so faraday_middleware is no longer needed.
- Add required_ruby_version >= 2.5.0 (required by Bundler 2.x) - Fix git ls-files to work properly when gem is installed from git - Suppress git errors with 2>/dev/null
The git ls-files approach causes 'undefined method identifier' error when the gem is installed via bundler from a git source. Using Dir.glob is more reliable for git-based gem installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The :json response middleware is now built into Faraday 2.x, so
faraday_middleware is no longer needed.
Description
Related Issue
Motivation and Context
Checklist: