docs: add Cursor Cloud specific instructions to AGENTS.md#73
docs: add Cursor Cloud specific instructions to AGENTS.md#73
Conversation
Co-authored-by: Krzysztof Ploch <kploch@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a 'Cursor Cloud specific instructions' section to AGENTS.md, providing an overview of the Ploch.Data library, required sibling repositories, and standardized build, test, and run commands. The review feedback suggests including the -p:UsePlochProjectReferences=true property in the dotnet run command for consistency and updating the 'No global.json' heading to accurately reflect that the file exists but is not used for SDK pinning.
| dotnet restore ./Ploch.Data.slnx -p:UsePlochProjectReferences=true | ||
| dotnet build ./Ploch.Data.slnx --no-restore -p:UsePlochProjectReferences=true | ||
| dotnet test ./Ploch.Data.slnx --no-build -p:UsePlochProjectReferences=true | ||
| dotnet run --project samples/SampleApp/src/ConsoleApp/Ploch.Data.SampleApp.ConsoleApp.csproj --no-build |
There was a problem hiding this comment.
To maintain consistency with the previous commands and the statement that all commands use UsePlochProjectReferences=true, it is recommended to include this property in the dotnet run command as well. This ensures that if the --no-build flag is removed, the command still functions as intended with project references.
| dotnet run --project samples/SampleApp/src/ConsoleApp/Ploch.Data.SampleApp.ConsoleApp.csproj --no-build | |
| dotnet run --project samples/SampleApp/src/ConsoleApp/Ploch.Data.SampleApp.ConsoleApp.csproj --no-build -p:UsePlochProjectReferences=true |
| - **NBGV shallow clone error**: If the build fails with `Shallow clone lacks the objects required to calculate version height`, the `ploch-common` repo needs `git fetch --unshallow`. | ||
| - **Duplicate import warning (MSB4011)**: `Ploch.Packages.props` is imported twice in `Directory.Packages.props`. This is a known non-blocking warning in the repo. | ||
| - **SQL Server test skipped**: `Data.EFCore.SqlServer.Tests` has one test explicitly skipped (`[Fact(Skip = ...)]`). No Docker/SQL Server setup is needed. | ||
| - **No `global.json`**: The repo does not pin SDK versions via `global.json`. The update script installs both .NET 8.0 and 10.0 SDKs. |
There was a problem hiding this comment.
The heading No global.json is misleading because a global.json file is present in the repository (as seen in Ploch.Data.slnx, line 102). It would be more accurate to state that the file exists but is not used for SDK pinning.
| - **No `global.json`**: The repo does not pin SDK versions via `global.json`. The update script installs both .NET 8.0 and 10.0 SDKs. | |
| - **global.json usage**: The repository contains a global.json file, but it does not pin specific SDK versions. The update script installs both .NET 8.0 and 10.0 SDKs. |
|
2 participants
Describe your changes
Adds a
## Cursor Cloud specific instructionssection toAGENTS.mdwith development environment setup guidance for cloud agents, including:mrploch-development,ploch-common)UsePlochProjectReferences=trueglobal.json, GitHub Packages NuGet auth)Issue ticket number and link
N/A — development environment setup
Checklist before requesting a review