[ios] Use runtime camera checks on simulator for camera availability#3724
Open
kmagiera wants to merge 1 commit intomrousavy:mainfrom
Open
[ios] Use runtime camera checks on simulator for camera availability#3724kmagiera wants to merge 1 commit intomrousavy:mainfrom
kmagiera wants to merge 1 commit intomrousavy:mainfrom
Conversation
## What Replace the unconditional simulator camera block with a runtime `AVCaptureDevice` availability check so simulator fallbacks only apply when no runtime video device exists. ## Changes - Replace the unconditional `#if targetEnvironment(simulator)` throw in `configureDevice(...)` with a simulator-only runtime check. - Keep throwing `device/camera-not-available-on-simulator` when `AVCaptureDevice.default(for: .video)` is unavailable. - Allow the normal camera configuration path when a runtime video device is present. - Clarify the inline simulator comment to describe the runtime source-availability behavior. ## Tested on - Code-path validation in this checkout (manual review only; no device/simulator runtime execution in this environment). ## Related issues - Inspired by [expo/expo#44159](expo/expo#44159).
|
@kmagiera is attempting to deploy a commit to the mrousavy's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the unconditional simulator camera block with a runtime
AVCaptureDeviceavailability check so simulator fallbacks only apply when no runtime video device exists.Changes
#if targetEnvironment(simulator)throw inconfigureDevice(...)with a simulator-only runtime check.device/camera-not-available-on-simulatorwhenAVCaptureDevice.default(for: .video)is unavailable.Tested on
Related issues