fix(ios): Fix iOS build with new architecture enabled#158
Closed
momomuchu wants to merge 1 commit intomrousavy:mainfrom
Closed
fix(ios): Fix iOS build with new architecture enabled#158momomuchu wants to merge 1 commit intomrousavy:mainfrom
momomuchu wants to merge 1 commit intomrousavy:mainfrom
Conversation
Fixes issue where iOS build fails with "RNTfliteSpec.h file not found" when React Native new architecture (TurboModules) is enabled. Changes: 1. Podspec: Merge pod_target_xcconfig instead of overwriting to preserve TensorFlow Lite settings when new architecture is enabled 2. Podspec: Add RCT-RCTFabric dependency for Fabric support 3. Podspec: Remove duplicate CLANG_CXX_LANGUAGE_STANDARD entries 4. iOS: Update RNTfliteSpec.h import to use correct path format (<RNTfliteSpec/RNTfliteSpec.h> instead of "RNTfliteSpec.h") The issue was caused by: - pod_target_xcconfig being redefined instead of merged, losing TensorFlow Lite preprocessor definitions - Incorrect header import path for Codegen-generated spec file Resolves: mrousavy#87
Author
|
ref issue: #87 |
|
I think you should also add this: node_modules/react-native-fast-tflite/ios/Tflite.mm (+1 -1)
57 {
58 - return std::make_shared<facebook::react::NativeTfliteSpecJSI>(params);
58 + return std::make_shared<facebook::react::NativeRNTfliteSpecJSI>(params);
59 }The TurboModule export now returns |
Owner
|
Hi - thanks for the PR - we recently migrated the library to Nitro and upgraded it to latest LiteRT, so I think this PR is quite out of sync now - sorry for not getting it merged sooner. I'm going to close this for now, but if this is still relevant in the latest version, we can open another PR and get it merged. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where iOS build fails with "RNTfliteSpec.h file not found" when React Native new architecture (TurboModules) is enabled.
Changes:
The issue was caused by:
Resolves: #87