Conversation
|
Thanks for this patch @mathew-bowersox . I'm assuming you are importing this in which case this patch will work fine for you. However as it stands this would break main() and the tests in main_test.go. If you could update this patch so that go test works. and main() still works. I'll merge the patch. Additionally to do this correctly main should be moved to cmd/jfect and package code should move to pkg along with tests. Then anything can import github.com/mrosset/jflect/pkg including cmd/jflect. |
…clarity and usage as a library.
main/main.go
Outdated
| import ( | ||
| "errors" | ||
| "flag" | ||
| "github.com/mathew-bowersox/jflect" |
There was a problem hiding this comment.
should be github.com/mrosset/jflect/pkg
package code should go into pkg/ directory
main/main.go
Outdated
| @@ -0,0 +1,31 @@ | |||
| // Copyright 2012 The jflect Authors. All rights reserved. | |||
There was a problem hiding this comment.
This file should now go into cmd/jflect directory
| @@ -1,4 +1,4 @@ | |||
| package main | |||
| package generate | |||
|
@mathew-bowersox thanks for the changes, just a couple of things to fix and then almost done. |
2 participants
Exporting your read function so it can be used when using your code as a library