Make compatible with Windows 10 > 15002#433
Open
jdmansour wants to merge 1 commit intomridgers:masterfrom
Open
Make compatible with Windows 10 > 15002#433jdmansour wants to merge 1 commit intomridgers:masterfrom
jdmansour wants to merge 1 commit intomridgers:masterfrom
Conversation
|
It’d be nice to get this released. |
|
@mridgers if in fact this resolves the issue, would it be possible to get this merged and release a new version? |
|
I strongly doubt that this will fix the issue any more—this was to do with Clink not loading at all, and dumping a relevant line to its log saying why it wasn’t willing to hook the function. Now, it hooks successfully, it’s just doskey macros aren’t working. I think this can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #431. It seems like in more recent builds of windows, a function that clink patches starts with a different instruction. I just added that instruction to the ones clink recognizes. My assembly is rusty, but it seems "mov rax,QWORD PTR [rsp]" just loads a value into rax in preparation of a function call, and it can be safely moved to the trampoline.
It works for me, but somebody who understands this stuff better should double check this :-).