Skip to content

bugfix/SW-4957 codex fails due to pkg resources dependency of markdown in octo print#132

Closed
hungerpirat wants to merge 3368 commits into
mrbeam2-alphafrom
bugfix/SW-4957-codex-fails-due-to-pkg-resources-dependency-of-markdown-in-octo-print
Closed

bugfix/SW-4957 codex fails due to pkg resources dependency of markdown in octo print#132
hungerpirat wants to merge 3368 commits into
mrbeam2-alphafrom
bugfix/SW-4957-codex-fails-due-to-pkg-resources-dependency-of-markdown-in-octo-print

Conversation

@hungerpirat
Copy link
Copy Markdown
Collaborator

No description provided.

StevilKnevil and others added 30 commits May 21, 2021 10:43
Also support quoted long names, which apparently are sent by some
firmwares? Make a suggestion for a format that is universally parseable,
document it on the reprep wiki, people STILL find a way to be
incompatible to it. I can't even...

Anyhow. See https://community.octoprint.org/t/adding-support-for-m20-l/34402
Includes proper handling auf cancel/pause situation, where we use the
position report as a signal that all movement has ended and the position
report should be used for final cancel/pause position, adds a new
terminal filter and also takes care of capability report evaluation and
proper interval setting via M154.

cc @thinkyhead - the cancel/pause situation worried me, so I took a look
how to solve it and that meant the implementation was already done as
well. Hope you don't hold it against me to tackle this myself after all.
Can of course be disabled.

Better implementation of OctoPrint#4148

Thanks you @apbarratt!
Phrasing improved and some copy-paste issues resolved as well.

Fixes OctoPrint#4160
Missed the 'reload settings' dialog when sorting out the animations, missed one
Many users are still copy/pasting the textual system info dump and
forget to share the bundle. Rephrase the request to target the bundle
and hide the info dump behind a More area. Also link to the bundle
viewer.
That way they won't get added to the backlog again on every single
server startup.

Fixes OctoPrint#4162
Instead of zero dimensions and bounding box we now just say "Model
contains no extrusion."

That should hopefully make it clear. Works for new analysis results with
`_empty` flag as well as analysis results with all 0 dimensions.

See also OctoPrint#4162
Now stuff should reload properly again on change.
This way our plugin AST parser routine becomes reusable in things like
the plugin manager.
Users now get a meaningful error message in both the plugin install log
as well as a clickable FAQ link in the plugin management log
notification.

Works for pip and single file installs.

Implements OctoPrint#4166
Can be used to hook into and prevent the start of a print job via click
on "Start" in the print state or click on select & print in the file
list.
Allows to inject additional commands into the system menu from plugins.

Implements OctoPrint#4143
Python 3.10 introduces a backwards incompatible change around collections and collections.abcs, which tornado was impacted by.

According to Tornado's release notes https://www.tornadoweb.org/en/stable/releases/v6.0.0.html seem like there is not much else to worry about, and the devel branch has already  upgraded it.

Would be good to get this tested by someone else using Python 3.10 and some plugins, and also some Python 2 installs.

See also OctoPrint#4043 for the other collections-related changes.
Introduced by OctoPrint#4116, seems I should have paid more attention and not just experimented in the devtools.
This broke sphinx autodoc, it would not pick up the module-level docstrings. In most cases, this was not really a problem but printer profiles documentation was missing quite a lot.
Now we fixed the docstrings, they are defining what is documented out of a module, so we don't need to include members in the top level file.
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
135 Security Hotspots
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.